logo elektroda
logo elektroda
X
logo elektroda

Verification Needed for 64-bit Flags Command on Multiple Platforms

XJ_ 981 38
ADVERTISEMENT
  • ADVERTISEMENT
  • #32 21459754
    divadiow
    Level 35  
    XJ_ wrote:
    Flag 13 on RTL8720D is not related to that PR


    No indeed, but just flagging (😂) it anyway
  • #33 21459788
    p.kaczmarek2
    Moderator Smart Home
    I've merged RTL8720D , I think I can soon setup a PR with per-platform testing enabled and I will ask you for testing then.

    Added after 19 [seconds]:

    And to get back on topic - I will add a FLAGS test as well... for 64-bit flags.
    Helpful post? Buy me a coffee.
  • ADVERTISEMENT
  • #34 21459792
    XJ_
    Level 11  
    p.kaczmarek2 wrote:
    And to get back on topic - I will add a FLAGS test as well... for 64-bit flags.

    I also plan to add some tests (for testing the tests ;-) ), maybe this weekend.
  • ADVERTISEMENT
  • Helpful post
    #35 21459843
    divadiow
    Level 35  
    no OTA on XR809 delayed things a little.
    Screenshot of OpenXR809 configuration with flags 0, 1, 2, and 3 enabled.
    flag 13 doesn't stick on reboot, otherwise fine.

    Added after 6 [hours] 23 [minutes]:

    TR6260 also accepted the new flag value but was missing flag 13 as has been seen before. On reboot the main GUI causes a system halt. Again I assume this relates to the flag 13 thing itself rather than your fix.

    Screenshot of OpenTR6260 interface with a list of flags and descriptions.

    Code: Text
    Log in, to see the code


    I don't this there's reason PR 1548 shouldn't be merged is there?
  • #36 21460545
    XJ_
    Level 11  
    divadiow wrote:
    I don't this there's reason PR 1548 shouldn't be merged is there?

    wow, what a nice piece of English language! I mean it in a good way, I don't know much English, but I like this sentence.
  • ADVERTISEMENT
  • #37 21460583
    divadiow
    Level 35  
    Ha. I typed the wrong word, too.

    "I don't think there's reason PR 1548 shouldn't be merged is there?"

    It still reads a bit awkward, though.
  • #38 21460593
    XJ_
    Level 11  
    ... and I thought, what kind of British dialect is that? ;-)
    You know, we who only know a little bit of Googlenglish :)
  • #39 21460862
    p.kaczmarek2
    Moderator Smart Home
    Merged, thank you, today I will update per platform tests so we can try running them.
    Helpful post? Buy me a coffee.

Topic summary

The discussion revolves around the modification of the Flags command to support 64-bit integers, with a focus on verifying its functionality across multiple platforms. The original implementation used two 32-bit integers due to historical limitations, but the transition to a single uint64_t is seen as a step towards future-proofing. Participants discuss potential issues with platform compatibility, particularly regarding the size of data types like 'long' on different architectures. Testing is emphasized, with suggestions for a self-test system to ensure consistent behavior across devices. Initial tests indicate successful flag setting, although some issues, such as a hard fault on the RTL-B platform, were noted. The conversation also touches on the importance of testing functions like strtoull() across various SDKs and the implementation of per-platform testing to catch platform-specific bugs.
Summary generated by the language model.
ADVERTISEMENT